Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changes facebook auth host to resolve JWT validation issue on version 5.x.x #9121

Closed

Conversation

chriscborg
Copy link
Contributor

Pull Request

Issue

Add support for Facebook auth JWT token #9117

Closes: #9117

Approach

A JWT token validation implementation seems to be already in place, however the host needs to be changed from facebook.com to www.facebook.com as suggested by @SebC99, because the old host is returning error 301 which is not followed by the jwt-rsa package.

Tasks

  • Add changes to documentation (guides, repository pages, code comments)

Copy link

Thanks for opening this pull request!

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parse Server 5 is not maintained anymore, we are not merging any PRs into this branch. Could you open a PR against the alpha branch instead, which is the current working branch?

@mtrezza mtrezza closed this May 8, 2024
@mtrezza
Copy link
Member

mtrezza commented May 8, 2024

I've closed this just to avoid confusion, as we already have 2 PRs open for PS 6 and 7, and this PR won't get merged as explained above.

@chriscborg
Copy link
Contributor Author

@mtrezza PR #9122 should be against alpha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants