Replace hackney with httpc #311
Conversation
|
Thanks. It's a little hectic week for me, but try to send message on the weekend / next week. |
|
@parroty hello! Any news on this? 🙃 |
|
@parroty ping 🙃 Would love to get an email and chat! 😉 |
|
@parroty ping 🏓 🙃 |
|
Sorry being slow to respond. I am seeing actions errors, but haven't been able look into it. Do you have any idea? |
|
@parroty finally fixed tests in CI on the supported versions, so this is ready to merge!!! Exciting times ahead. 💟 |
| @@ -25,8 +25,8 @@ jobs: | |||
| - uses: actions/cache@v3 | |||
| with: | |||
| path: deps | |||
| key: ${{ runner.os }}-mix-${{ hashFiles(format('{0}{1}', github.workspace, '/mix.lock')) }} | |||
| key: ${{ runner.os }}-${{ matrix.elixir }}-otp${{ matrix.otp }}-mix-${{ hashFiles(format('{0}{1}', github.workspace, '/mix.lock')) }} | |||
There was a problem hiding this comment.
@parroty having a single cache for all OTP versions causes issues when testing across different versions. Most projects I've used actually go with a per-version cache, so this is what this change is.
|
@parroty any news on this? 🙃 |
|
Tested this out in Xandra, works good 🙃 |
|
Woohooo! Thanks @parroty. Looking forward to a release 😉 |
| Application.ensure_all_started(:hackney) | ||
| defp upload_zipped_json(content, options) do | ||
| Application.ensure_all_started(:ssl) | ||
| Application.ensure_all_started(:httpc) |
There was a problem hiding this comment.
Out of curiosity, why does :httpc needs to be started explicitly? Starting :inets.start() and :ssl.start() typically was sufficient for me in the past 🤔
There was a problem hiding this comment.
It probably is sufficient, I just overlooked this. PRs welcome 😉
There was a problem hiding this comment.
Thanks for the comment. Do you see specific negative implication for this extra start logic? (Just a small overhead?).
I'll be publishing the release later today (after going back home), but wondering whether to update this before the release.
This is the start of the work proposed in #231.
The main missing thing is Security™, that is, I need to add all the right SSL options to make the
:httpcrequest secure. I'll work on that this afternoon if there is interest in this, @parroty?Btw @parroty, also feel free to send me an email (email is on my GitHub profile) or write me a DM on Twitter to chat about helping out with maintaining this library 🙃