New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always floor coverage instead of rounding #310
Conversation
88789a3
to
02537f4
Compare
@parroty any news on this? |
Thanks for the follow-up 🙇 . Please let me separate this item from the current |
@parroty interested when this is going out to hex, we are running into this on our CI reporting 100% even though it's not actually 100% |
I'm sorry about not responding to this... I have some concerns around the compatibility part. Could anyone help adding this as configuration option, as opt-in? 🙇 |
Hi @parroty, I understand your concerns about being retro-compatible but I think the actual behaviour is conceptually wrong (showing 100% coverage when some lines are not covered). Are you open to adding a configuration option to restore the previous behaviour and make the floor coverage the default one? I.e. having an opt-out option instead of opt-in as you suggested |
Thank you for the comment 🙇 . I was originally thinking about maintaining the current behavior ( |
Perfect, I'll add the option to this PR in a couple of days, thank you |
We do not want to report a 100% coverage when there are lines that are not covered.
02537f4
to
0251b29
Compare
@parroty ready |
Thank you! (I'll be publishing the new version later). |
We do not want to report a 100% coverage when there are lines that are not covered.