Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #284

Closed
wants to merge 1 commit into from
Closed

Update README.md #284

wants to merge 1 commit into from

Conversation

deepfryed
Copy link

Update README with instructions on silencing OTP warnings

Update README with instructions on silencing OTP warnings
@coveralls
Copy link

coveralls commented Jul 13, 2022

Coverage Status

Coverage increased (+0.02%) to 90.485% when pulling 419f02e on deepfryed:patch-1 into 0bc6940 on parroty:master.

Copy link
Owner

@parroty parroty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Could I request one change?

@@ -475,6 +475,18 @@ end
- When erlang version 17.3 is used, an error message `(MatchError) no match of right hand side value: ""` can be shown. Refer to issue #14 for the details.
- https://github.com/parroty/excoveralls/issues/14

### Silence OTP Cover Warnings
To remove OTP warnings about modules or specific logging, please open a GitHub issue in the Erlang OTP repository. Alternatively you can copy the `cover.erl` file under `src/` of your Elixir project and modify it to remove the warnings.
Copy link
Owner

@parroty parroty Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the open a GitHub issue in the Erlang OTP repository is a separate discussion topic from the procedure itself. Can we exclude it this part? (may be like the following?)

To remove OTP warnings about modules or specific logging, you can copy the cover.erl file under src/ of your Elixir project and modify it to remove the warnings, as a tentative solution.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, it might be easier for you to cherry pick what's needed and update README directly.

Copy link
Owner

@parroty parroty Jul 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I'll update the README separately (thank you for the contribution).
I tried to update the PR itself, but couldn't do that, maybe because it's coming from a fork.

@parroty
Copy link
Owner

parroty commented Jul 14, 2022

Superseded by #285.

@parroty parroty closed this Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants