New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #284
Update README.md #284
Conversation
Update README with instructions on silencing OTP warnings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! Could I request one change?
@@ -475,6 +475,18 @@ end | |||
- When erlang version 17.3 is used, an error message `(MatchError) no match of right hand side value: ""` can be shown. Refer to issue #14 for the details. | |||
- https://github.com/parroty/excoveralls/issues/14 | |||
|
|||
### Silence OTP Cover Warnings | |||
To remove OTP warnings about modules or specific logging, please open a GitHub issue in the Erlang OTP repository. Alternatively you can copy the `cover.erl` file under `src/` of your Elixir project and modify it to remove the warnings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the open a GitHub issue in the Erlang OTP repository
is a separate discussion topic from the procedure itself. Can we exclude it this part? (may be like the following?)
To remove OTP warnings about modules or specific logging, you can copy the
cover.erl
file undersrc/
of your Elixir project and modify it to remove the warnings, as a tentative solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, it might be easier for you to cherry pick what's needed and update README directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I'll update the README separately (thank you for the contribution).
I tried to update the PR itself, but couldn't do that, maybe because it's coming from a fork.
Superseded by #285. |
Update README with instructions on silencing OTP warnings