Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with CircleCI parallel workflows not picking up separate builds #228

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Fix issue with CircleCI parallel workflows not picking up separate builds #228

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f31267
add node index to circle service_job_id
dhaspden Sep 18, 2020
f49517a
update explanation about service_job_id
dhaspden Sep 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/excoveralls/circle.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,9 @@ defmodule ExCoveralls.Circle do

defp get_job_id do
# When using workflows, each job has a separate `CIRCLE_BUILD_NUM`, so this needs to be used as the Job ID and not
# the Job Number.
System.get_env("CIRCLE_BUILD_NUM")
# the Job Number. If the job is configured with `parallelism` greater than one, then the `CIRCLE_NODE_INDEX` is
# used to differentiate between separate containers running the same job.
"#{System.get_env("CIRCLE_BUILD_NUM")}-#{System.get_env("CIRCLE_NODE_INDEX")}"
end

defp get_number do
Expand Down