Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with CircleCI parallel workflows not picking up separate builds #228

Merged
merged 2 commits into from Sep 22, 2020

Conversation

dhaspden
Copy link
Contributor

In our experience using mix coveralls.circle --parallel --umbrella the parallel jobs are reported using a duplicate service_job_id. I've added the CIRCLE_NODE_INDEX as suggested on the main Coveralls repository at lemurheavy/coveralls-public#1341 (comment).

I am not sure if this is backwards incompatible for older CircleCI users, might be good for them to test this and chime in as well.

@coveralls
Copy link

coveralls commented Sep 18, 2020

Coverage Status

Coverage remained the same at 89.778% when pulling f49517a on dhaspden:master into 5de0b8a on parroty:master.

@parroty parroty merged commit 33e815d into parroty:master Sep 22, 2020
@parroty
Copy link
Owner

parroty commented Sep 22, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants