move2kube workflow using ssh keys instead of token #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-farache
changed the title
pkliczewski
reviewed
Jan 4, 2024
m2k/serverless-workflow-m2k/src/main/resources/application-knative.properties
Show resolved
Hide resolved
gabriel-farache
changed the title
gabriel-farache
force-pushed
the
feat/m2k_ssh
branch
from
f15c566
to
cb612f4
Compare
pkliczewski
reviewed
Jan 8, 2024
gabriel-farache
force-pushed
the
feat/m2k_ssh
branch
2 times, most recently
from
abb79c2
to
ee80ec6
Compare
gabriel-farache
force-pushed
the
feat/m2k_ssh
branch
from
ee80ec6
to
be6ee4c
Compare
|
/lgtm |
|
@masayag please review and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #8
This PR changes the way the workflow and the move2kube instance interact with the private git repo: instead of using a token, they are using ssh keys previously added to the account (ie: https://bitbucket.org/account/settings/ssh-keys/)
By using the ssh keys, the move2kube instance can clone the repository when creating a plan. Thus, enabling the workflow to use the
remote-sourcequery param and removing the need for theCreatePlanKnative function.Once konveyor/move2kube#1126 is merged, we can revert back to using the
konveyorimagesSolves https://issues.redhat.com/browse/FLPATH-820