Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle debug info #16

Merged
merged 1 commit into from Jun 6, 2022
Merged

handle debug info #16

merged 1 commit into from Jun 6, 2022

Conversation

mangas
Copy link
Contributor

@mangas mangas commented May 19, 2022

Fixes #15.

Waiting on paritytech/parity-wasm#328 to be merged to update the Cargo.toml on this PR

src/gas_metering/mod.rs Outdated Show resolved Hide resolved
@athei
Copy link
Member

athei commented May 20, 2022

Please run cargo +nightly fmt. PR cluttered with stylistic noise.

@mangas
Copy link
Contributor Author

mangas commented May 25, 2022

@athei the parity-wasm dependency is set to master because the previous PR (paritytech/parity-wasm#328) has been merged but I was unable to get someone to tag it. Are you ok moving on with master? Would you be able to create the tag?

@athei
Copy link
Member

athei commented May 26, 2022

Just did a release to crates.io and updated your manifest.

Cargo.toml Outdated Show resolved Hide resolved
@mangas
Copy link
Contributor Author

mangas commented May 26, 2022

Just did a release to crates.io and updated your manifest.

Thank you 🙏

@mangas mangas requested a review from athei May 26, 2022 12:26
@mangas
Copy link
Contributor Author

mangas commented May 26, 2022

@athei checks got cancelled, could you re-run please?

@athei
Copy link
Member

athei commented May 26, 2022

They got canceled because they failed. So re-running wouldn't make the CI failure go away. It is just some little changes introduced by the bumped wasmparser version.

@mangas mangas force-pushed the master branch 2 times, most recently from a411fed to 7a02a05 Compare May 26, 2022 13:15
@mangas
Copy link
Contributor Author

mangas commented May 26, 2022

They got canceled because they failed. So re-running wouldn't make the CI failure go away. It is just some little changes introduced by the bumped wasmparser version.

Yep sorry, I open the first few ones and missed the red test 😄 Fixed the changes as well

@mangas
Copy link
Contributor Author

mangas commented May 26, 2022

@athei will you be able to push a new tag/release for this repo as well in the near future? Would be really appreciated

src/gas_metering/mod.rs Show resolved Hide resolved
tests/diff.rs Outdated Show resolved Hide resolved
@mangas mangas requested a review from athei June 6, 2022 12:33
@athei athei merged commit 4a51f16 into paritytech:master Jun 6, 2022
@sinkingsugar
Copy link

sinkingsugar commented Jun 7, 2022

Fyi this broke our substrate build using pallet-contracts, parity-wasm 0.45 seems conflicting (with the rest of the runtime build).

Just noticed desc... well issue is it broke June Tag build as well :) cos contracts has 0.1 only.... I suggest bumping to 0.2.x

@@ -20,7 +20,7 @@ lto = "fat"
codegen-units = 1

[dependencies]
parity-wasm = { version = "0.42", default-features = false }
parity-wasm = { version = "0.45", default-features = false }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke Semver as parity-wasm types are used in the public interface

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update debug information when injecting gas metering
4 participants