New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle debug info #16
Conversation
Please run |
fc2d4d6
to
d464972
Compare
@athei the parity-wasm dependency is set to master because the previous PR (paritytech/parity-wasm#328) has been merged but I was unable to get someone to tag it. Are you ok moving on with master? Would you be able to create the tag? |
Just did a release to crates.io and updated your manifest. |
Thank you 🙏 |
@athei checks got cancelled, could you re-run please? |
They got canceled because they failed. So re-running wouldn't make the CI failure go away. It is just some little changes introduced by the bumped wasmparser version. |
a411fed
to
7a02a05
Compare
Yep sorry, I open the first few ones and missed the red test 😄 Fixed the changes as well |
@athei will you be able to push a new tag/release for this repo as well in the near future? Would be really appreciated |
Fyi this broke our substrate build using Just noticed desc... well issue is it broke June Tag build as well :) cos contracts has |
@@ -20,7 +20,7 @@ lto = "fat" | |||
codegen-units = 1 | |||
|
|||
[dependencies] | |||
parity-wasm = { version = "0.42", default-features = false } | |||
parity-wasm = { version = "0.45", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This broke Semver as parity-wasm types are used in the public interface
Fixes #15.
Waiting on paritytech/parity-wasm#328 to be merged to update the Cargo.toml on this PR