Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be sufficient to add
Stronghold
here, I thinktidext
will cause confusion.I guess you need some tweaks to subxt, perhaps you are using some other polkadot/substrate tags or what it's the reason behind the fork?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey guys, thanks for review!
The main reason is that we need to have substrate locked to the same version that our chain and our primitives as they are shared between different services.
Once we stabilize everything, we should be good to use the same substrate version that
subxt
use and delete the fork.There is no missing features in
subxt
, we had some previously but you guys fixed them all!PS; I removed the
Stronghold
link to prevent any confusionThanks again!