Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tidext in real world usage #508

Merged
merged 2 commits into from Apr 14, 2022
Merged

Conversation

lemarier
Copy link
Contributor

@lemarier lemarier commented Apr 8, 2022

Signed-off-by: David Lemarier david@lemarier.ca

Signed-off-by: David Lemarier <david@lemarier.ca>
@cla-bot-2021
Copy link

cla-bot-2021 bot commented Apr 8, 2022

User @lemarier, please sign the CLA here.

@jsdw
Copy link
Collaborator

jsdw commented Apr 10, 2022

Dumb question maybe, but could you point me to the usage of subxt in that project; I can't find anything offhand (https://github.com/iotaledger/stronghold.rs/search?q=subxt)?

@lemarier
Copy link
Contributor Author

lemarier commented Apr 10, 2022

Dumb question maybe, but could you point me to the usage of subxt in that project; I can't find anything offhand (https://github.com/iotaledger/stronghold.rs/search?q=subxt)?

Hey @jsdw , this is not a dumb question!
Maybe I should remove the Stronghold link to prevent confusion? (let me know if you want me to proceed)

This is the Stronghold signer integration:
https://github.com/tidelabs/tidext/blob/dev/tidext/src/keyring/stronghold.rs

The documentation is available here as well;
https://tidelabs.github.io/tidext/

Hope this help

@niklasad1
Copy link
Member

niklasad1 commented Apr 10, 2022

@jsdw note that tidext is a fork of subxt that's probably why you didn't found it ^^

@jsdw
Copy link
Collaborator

jsdw commented Apr 11, 2022

Aha, thanks guys, confusion cleared up :)

(I would be curious to know why you forked Subxt though! Was it missing some crucial features?)

@jsdw jsdw requested a review from a team April 11, 2022 13:55
README.md Outdated
@@ -108,6 +108,7 @@ Please add your project to this list via a PR.
- [phala-pherry](https://github.com/Phala-Network/phala-blockchain/tree/master/standalone/pherry) The relayer between Phala blockchain and the off-chain Secure workers.
- [crunch](https://github.com/turboflakes/crunch) CLI to claim staking rewards in batch every Era or X hours for substrate-based chains.
- [interbtc-clients](https://github.com/interlay/interbtc-clients) Client implementations for the interBTC parachain; notably the Vault / Relayer and Oracle.
- [tidext](https://github.com/tidelabs/tidext) Tidechain client with [Stronghold](https://github.com/iotaledger/stronghold.rs) signer.
Copy link
Member

@niklasad1 niklasad1 Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be sufficient to add Stronghold here, I think tidext will cause confusion.

I guess you need some tweaks to subxt, perhaps you are using some other polkadot/substrate tags or what it's the reason behind the fork?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey guys, thanks for review!

The main reason is that we need to have substrate locked to the same version that our chain and our primitives as they are shared between different services.

Once we stabilize everything, we should be good to use the same substrate version that subxt use and delete the fork.

There is no missing features in subxt, we had some previously but you guys fixed them all!

PS; I removed the Stronghold link to prevent any confusion

Thanks again!

Signed-off-by: David Lemarier <david@lemarier.ca>
@jsdw jsdw requested a review from niklasad1 April 14, 2022 16:21
@niklasad1 niklasad1 merged commit e0439c9 into paritytech:master Apr 14, 2022
@lemarier lemarier deleted the lemarier-tidext branch April 14, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants