This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Migrate pallet-offences to pallet attribute macro #8763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
User @stanly-johnson, please sign the CLA here. |
shawntabrizi
reviewed
May 9, 2021
shawntabrizi
reviewed
May 9, 2021
|
some other spots where tabs needed too |
|
Also compile locally to check for unused imports like this: |
…tanly-johnson/substrate into stanly-migrate-pallet-offences
shawntabrizi
added
B0-silent
thiolliere
added
A0-please_review
shawntabrizi
approved these changes
May 12, 2021
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit 
viniul
added
D1-audited 👍
nazar-pc
pushed a commit
to subspace/substrate
that referenced
this pull request
Aug 8, 2021
* update to pallet macro * fixes * fix tests * remove unwanted generic * fix conflict * Fix storage and tabs Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7882.
Converts the Offences pallet to the new pallet attribute macro introduced in #6877.
Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.
From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines
storages now use PalletInfo for module_prefix instead of the one given to decl_storage: Thus any use of this pallet in construct_runtime! should be careful to update name in order not to break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change.