This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Migrate pallet-nicks to pallet attribute macro. #8723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaunxw
commented
May 4, 2021
| } | ||
| /// The minimum length a name may be. | ||
| #[pallet::constant] | ||
| type MinLength: Get<u32>; |
There was a problem hiding this comment.
I guess it should be fine to change it to Get<u32> here? The type in metadata is Get<u32>. Cannot find a better way to keep metadata type as Get<u32> type without changing the type in Config. #[pallet::extra_constant] seems for this scenario but the constant name will change, as functions in it should be named as snake case.
There was a problem hiding this comment.
yes it is better now to me too
thiolliere
added
A0-please_review
thiolliere
approved these changes
May 5, 2021
| } | ||
| /// The minimum length a name may be. | ||
| #[pallet::constant] | ||
| type MinLength: Get<u32>; |
There was a problem hiding this comment.
yes it is better now to me too
shawntabrizi
approved these changes
May 5, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit 
nazar-pc
pushed a commit
to subspace/substrate
that referenced
this pull request
Aug 8, 2021
* Migrate pallet-nicks to pallet attribute macro. * Fix constants.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7882.
Converts the
Nickspallet to the new pallet attribute macro introduced in #6877.Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.
From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines
So users of the
Nickspallet must be careful about the name they used inconstruct_runtime!. Hence theruntime-migrationlabel, which might not be needed depending on the configuration of theNickspallet.