This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
[client cli] generic blocknumber #4376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @niklasad1 signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
niklasad1
commented
Dec 12, 2019
| pub fn parse<N>(&self) -> Result<N, String> | ||
| where | ||
| N: FromStr, | ||
| N::Err: std::fmt::Debug, |
There was a problem hiding this comment.
just for printing the error which can be useful
niklasad1
commented
Dec 12, 2019
| /// | ||
| /// See `https://doc.rust-lang.org/std/primitive.str.html#method.parse` for more elaborate | ||
| /// documentation. | ||
| pub fn parse<N>(&self) -> Result<N, String> |
There was a problem hiding this comment.
nothing prevents parsing BlockNumber to a signed integer thus it relies on each type's FromStr` implementation.
If the value is bigger than 2^(n-1) it will be an Overflow for the types in core::num at least, where n is the number of bits of the integer.
arkpar
approved these changes
Dec 17, 2019
bkchr
approved these changes
Dec 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to close #2653
It changes that
block numberis hardcoded to u32 instead it stores aStringand parses it at runtime to appropriate type.