Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[contracts] stabilize seal_contains_storage(vseal0) and seal_set_storage (v.seal1) #11378

Merged
merged 1 commit into from
May 10, 2022

Conversation

agryaznov
Copy link
Contributor

(Needed for ink! 3.1 release)

ink#1242 updates E2E tests to cover these functions, and should be merged into master right before the 3.1 ink release.

Hence this PR stabilizes them:

  • [seal0] seal_contains_storage
  • [seal1] seal_set_storage

@agryaznov agryaznov added A0-please_review Pull request needs code review. B3-apinoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 9, 2022
@agryaznov agryaznov requested a review from athei as a code owner May 9, 2022 12:53
@agryaznov agryaznov added this to In Progress in Smart Contracts via automation May 9, 2022
@agryaznov
Copy link
Contributor Author

@cmichi I'm not sure if [seal1] seal_set_storage is really covered by E2E tests, could you please elaborate on this?

@athei
Copy link
Member

athei commented May 9, 2022

@cmichi I'm not sure if [seal1] seal_set_storage is really covered by E2E tests, could you please elaborate on this?

AFAIK every example that uses storage uses the new seal_set_storage version.

Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@athei athei requested a review from cmichi May 9, 2022 13:27
@athei
Copy link
Member

athei commented May 10, 2022

bot merge

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants