Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primitive-types: use weak dep feature #664

Merged
merged 1 commit into from Aug 16, 2022
Merged

primitive-types: use weak dep feature #664

merged 1 commit into from Aug 16, 2022

Conversation

ordian
Copy link
Member

@ordian ordian commented Aug 15, 2022

Fixes #475. Closes #630.

Cargo 1.60 which was released in April stabilized weak dependency feature 1 which in this case won't pull impl-codec if std is enabled unless codec feature is also activated.

Footnotes

  1. https://doc.rust-lang.org/stable/cargo/reference/features.html#dependency-features

@ordian ordian merged commit df78257 into master Aug 16, 2022
@ordian ordian deleted the ao-weak-features branch August 16, 2022 09:34
@ordian ordian added breaking-change Breaking change changelog Needs to be added to the changelog labels Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Breaking change changelog Needs to be added to the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ethereum-types/std always pulls in codec
3 participants