Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(log): downgrade send errors to warn #726

Merged
merged 1 commit into from Apr 5, 2022

Conversation

niklasad1
Copy link
Member

These logs are most likely related to that the client terminated the connection
and they come with significant overhead because it occurs almost on every connection reset.

These logs are most likely related to that the client terminated the connection
and they come with significant overhead.
@niklasad1 niklasad1 requested a review from a team as a code owner April 5, 2022 16:41
@niklasad1 niklasad1 mentioned this pull request Apr 5, 2022
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the simplication of the error messages are also nice.

@niklasad1 niklasad1 merged commit 2f5fef2 into master Apr 5, 2022
@niklasad1 niklasad1 deleted the na-downgrade-send-errors-to-warn- branch April 5, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants