fix(http server): handle post and option HTTP requests properly. #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
commented
Jan 4, 2022
TarikGul
approved these changes
Jan 4, 2022
jsdw
reviewed
Jan 4, 2022
jsdw
reviewed
Jan 4, 2022
niklasad1
commented
Jan 4, 2022
http-server/src/server.rs
Outdated
| @@ -302,116 +302,25 @@ impl<M: Middleware> Server<M> { | |||
| // two cases: a single RPC request or a batch of RPC requests. | |||
| async move { | |||
| if let Err(e) = access_control_is_valid(&access_control, &request) { | |||
There was a problem hiding this comment.
this became hard to review, however validate origins and headers before checking the method kind.
niklasad1
commented
Jan 4, 2022
| @@ -469,3 +375,110 @@ fn is_json(content_type: Option<&hyper::header::HeaderValue>) -> bool { | |||
| _ => false, | |||
| } | |||
| } | |||
|
|
|||
| /// Process a verified request, it implies a POST request with content type JSON. | |||
| async fn process_validated_request( | |||
There was a problem hiding this comment.
move to a separate function to decrease the indentation level and become more readable...
niklasad1
changed the title
niklasad1
commented
Jan 5, 2022
niklasad1
commented
Jan 5, 2022
niklasad1
commented
Jan 5, 2022
niklasad1
commented
Jan 5, 2022
niklasad1
commented
Jan 5, 2022
niklasad1
commented
Jan 5, 2022
niklasad1
commented
Jan 5, 2022
…tech/jsonrpsee into na-fix-http-server-options-method
niklasad1
commented
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly fixes #628