Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clients: use FxHashMap instead FnvHashMap #592

Merged
merged 2 commits into from
Dec 7, 2021
Merged

clients: use FxHashMap instead FnvHashMap #592

merged 2 commits into from
Dec 7, 2021

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented Dec 7, 2021 •
edited

FxHashMap is already used in the utils crate then let's use it in the clients too because it's faster and to reduce the dependencies a bit.

@niklasad1 niklasad1 requested a review from a team as a code owner December 7, 2021 13:59
insipx
insipx approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@insipx insipx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always nice to be consistent!

@niklasad1 niklasad1 merged commit 7bb628a into master Dec 7, 2021
@niklasad1 niklasad1 deleted the na-kill-fnvhashmap branch December 7, 2021 15:49
@dvdplm
Copy link
Contributor

dvdplm commented Dec 7, 2021

Include in 0.6.1?

@niklasad1
Copy link
Member Author

already released :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@insipx insipx insipx approved these changes

@TarikGul TarikGul TarikGul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@niklasad1 @dvdplm @insipx @TarikGul