Suppress unused variable warning for debug_print macros #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athei
requested review from
Robbepop,
cmichi,
ascjones and
HCastano
as code owners
athei
changed the title
ascjones
approved these changes
May 17, 2022
cmichi
approved these changes
May 17, 2022
agryaznov
added a commit
that referenced
this pull request
May 17, 2022
|
Any idea why the waterfall is failing? The error seems cryptic to me. |
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑
These are the results when building the
Link to the run | Last update: Wed May 18 08:41:17 CEST 2022 |
Codecov Report
@@ Coverage Diff @@
## master #1258 +/- ##
===========================================
- Coverage 79.12% 62.30% -16.83%
===========================================
Files 227 227
Lines 8638 8638
===========================================
- Hits 6835 5382 -1453
- Misses 1803 3256 +1453
Continue to review full report at Codecov.
|
Just reran it, this worked, I think it was a temporary network failure. |
|
The size report of the waterfall seems buggy. It reports its whole size as increase. |
agryaznov
added a commit
that referenced
this pull request
May 18, 2022
This reverts commit 3491cfd.
agryaznov
added a commit
that referenced
this pull request
May 18, 2022
* first iteration of the BIOC * clippy fixes * suppress unused var warning for debug fn * suppress unused var warning 2nd try * + tests * Apply suggestions from code review Co-authored-by: Alexander Theißen <alex.theissen@me.com> * renamed to `mother`; added storage * refactor * added a Mapping into contract storage * default constructor * reverted fix * fix * Apply suggestions from code review Co-authored-by: Alexander Theißen <alex.theissen@me.com> * make it build (but not instantiate) * fmt * Update examples/mother/lib.rs Co-authored-by: Alexander Theißen <alex.theissen@me.com> * Apply suggestions from code review Co-authored-by: Alexander Theißen <alex.theissen@me.com> * reverted constructor delegation to satisfy CI (until #1259 fixed) * added required input types * custom event added * CI clippy satisfaction * trick to satisfy the CI until #1258 is fixed * Revert "trick to satisfy the CI until #1258 is fixed" This reverts commit 3491cfd. Co-authored-by: Alexander Theißen <alex.theissen@me.com>
|
Now if I remove "ink-debug" from |
|
Thanks for reporting. I thought this case would have been covered by CI. Apparently not. Can you create an issue from that? |
cmichi
added a commit
that referenced
this pull request
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a variable is only used in the
debug_print(ln)?macro then a unused variable warning is emitted in case theink-debugfeature isn't used. This fixes this problem by always using the arguments without evaluating them: Capture them by reference in a closure that is never executed.@agryaznov had this problem in his mother contract.