This repository has been archived by the owner on Feb 28, 2023. It is now read-only.
Migrate to stable Future trait, async/await and Tokio 0.2 runtime #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xanewok
force-pushed
the
igor-migrate-to-stable-future
branch
2 times, most recently
from
ac839b2
to
c4454c7
Compare
drahnr
approved these changes
May 2, 2021
|
We probably should merge #67 first, then this. |
Co-authored-by: Igor Matuszewski <xanewok@gmail.com>
This fixes a bug introduced during the futures rewrite - we eagerly returned from the function rather than, as we did originally, falling back to compiling without proxy.
Xanewok
force-pushed
the
igor-migrate-to-stable-future
branch
from
c4454c7
to
97fb07e
Compare
This was referenced May 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirror of mozilla/sccache#985
Closes #31