Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include required CLI command for --bundle-node-modules #986

Open
wants to merge 2 commits into
base: v2
Choose a base branch
from

Conversation

jeff-hykin
Copy link

Added the --target default example because without it parcel 2 gives the extremely unhelpful message of

🚨 Build failed.

Error: Bundles must have unique names

  AssertionError [ERR_ASSERTION]: Bundles must have unique names
  at BundlerRunner.nameBundles (/Users/jeffhykin/repos/vibrance/node_modules/@parcel/core/lib/requests/BundleGraphRequest.js:343:23)
  at processTicksAndRejections (node:internal/process/task_queues:94:5)
  at async BundlerRunner.bundle (/Users/jeffhykin/repos/vibrance/node_modules/@parcel/core/lib/requests/BundleGraphRequest.js:286:5)
  at async RequestTracker.runRequest (/Users/jeffhykin/repos/vibrance/node_modules/@parcel/core/lib/RequestTracker.js:721:20)
  at async Object.run (/Users/jeffhykin/repos/vibrance/node_modules/@parcel/core/lib/requests/ParcelBuildRequest.js:62:7)
  at async RequestTracker.runRequest (/Users/jeffhykin/repos/vibrance/node_modules/@parcel/core/lib/RequestTracker.js:721:20)
  at async Parcel._build (/Users/jeffhykin/repos/vibrance/node_modules/@parcel/core/lib/Parcel.js:397:11)
  at async Parcel.run (/Users/jeffhykin/repos/vibrance/node_modules/@parcel/core/lib/Parcel.js:275:18)
  at async run (/Users/jeffhykin/repos/vibrance/node_modules/parcel/lib/cli.js:374:7)

@height
Copy link

height bot commented Dec 13, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@vercel
Copy link

vercel bot commented Dec 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/devongovett/website/Hsh8ftkVazQwMcEvcxm7ksqseZgw
✅ Preview: https://website-git-fork-jeff-hykin-patch-3-devongovett.vercel.app


{% samplefile %}
```bash
parcel build index.js --target default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should not be required in the example here. You probably have some other configuration in your project that isn't in the example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants