Update hmr.md #463
Closed
Update hmr.md #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify that HMR is now opt-in. See parcel-bundler/parcel#2676 (comment)
|
This pull request is automatically deployed with Now. |
mischnic
reviewed
Jun 24, 2019
src/i18n/en/docs/hmr.md
Outdated
| Hot Module Replacement (HMR) improves the development experience by automatically updating modules in the browser at runtime without needing a whole page refresh. This means that application state can be retained as you change small things. Parcel's HMR implementation supports both JavaScript and CSS assets out of the box. HMR is automatically disabled when bundling in production mode. | ||
| Hot Module Replacement (HMR) improves the development experience by automatically updating modules in the browser at runtime without needing a whole page refresh. This means that application state can be retained as you change small things. Parcel's HMR implementation supports both JavaScript and CSS assets. | ||
|
|
||
| As of version 1.12.x, the default implementation has changed to fully refresh the page when files change. You can opt-in to enable true HMR by calling `module.hot.accept()` in your app. HMR is automatically disabled when bundling in production mode. |
There was a problem hiding this comment.
The last sentence can be a bit deceiving, you definitely need an enclosing if(module.hot).... otherwise there will be an error in production that module.hot is undefined .
"1.12.x" isn't really a version, the change was in 1.12.0.
DeMoorJasper
approved these changes
Jul 2, 2019
mischnic
approved these changes
Oct 5, 2019
|
Apparently the original branch this PR is comparing to dissapeared, so we can't merge this... |
Merged
|
Oh! I must've cleaned house and forgot that this PR was still extant. Thanks for setting it up separately. Sorry about the inconvenience 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify that HMR is now opt-in. See parcel-bundler/parcel#2676 (comment)