Add parcel config crate #9700
Merged
Add parcel config crate #9700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamadapc
reviewed
May 7, 2024
MonicaOlejniczak
force-pushed
the
molejniczak/parcel-config
branch
from
38029f9
to
1a146e5
Compare
yamadapc
reviewed
May 7, 2024
| }; | ||
| } | ||
|
|
||
| test_pipeline_map!(compressors); |
There was a problem hiding this comment.
I'd personally write helper functions rather than macro it unless not possible because macros mess-up a lot of IDE features
There was a problem hiding this comment.
Yeah I get that, but there's far too much repetition / not enough coverage without the use of macros.
yamadapc
approved these changes
May 7, 2024
MonicaOlejniczak
force-pushed
the
molejniczak/parcel-config
branch
from
1a146e5
to
f2e71bf
Compare
MonicaOlejniczak
force-pushed
the
molejniczak/parcel-config
branch
from
f2e71bf
to
aeae775
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This change introduces a new
parcel_configcrate that ports some of the logic in v2...core-rs2 and ultimately expands on the implementation there.package_managercrate and trait to add as a dependency of the config🚨 Test instructions
cargo test -p parcel_config