New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump napi-rs #9699
base: v2
Are you sure you want to change the base?
Bump napi-rs #9699
Conversation
5cdd7ae
to
e0fc759
Compare
.github/workflows/ci.yml
Outdated
@@ -21,7 +21,7 @@ jobs: | |||
cache: yarn | |||
- uses: dtolnay/rust-toolchain@master | |||
with: | |||
toolchain: 1.77 | |||
toolchain: stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we should stay on a pinned release of Rust, and update it manually? Or just stay on stable
and pin only when it breaks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or just stay on stable and pin only when it breaks?
Yes, that's what I would have suggested (= what we've done so far). Requires less maintenance from our side as well
Do you have any clues as to why integration tests are still failing? I cloned this branch locally and built it and it seems to work okay for a quick smoke test (building a smaller part of our application as a production build locally). I've double checked and it's build with Rust 1.78 and running with Node v18.20.1 (on an M1 Mac) |
My only guess is that it's the same stack overflow as #9574 But we'll see what happens when rebasing this after merging the swc bump. |
Now it's again crashing only on Windows, so probably the same stack problem as with the swc PR |
It looks like everything is working again now - likely as you suspected, the SWC stack changes might've fixed this. Are there any blockers to taking this out of Draft and getting it shipped? For context, keen on being able to get a Rust 1.78 based build as the EDIT: I pulled in latest v2 changes and still getting Windows integration test failures with |
Bump napi-rs to include the fix for napi-rs/napi-rs#2085
and revert Rust version change (#9696, #9697) againRust 1.77 enabled dev assertions in the stdlib, which makes it more strict in dev builds.
There was a bug in napi-rs that was previously unnoticed because there were no assertions: