Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow both service_worker and scripts in MV3 Web Extensions #9673

Merged
merged 4 commits into from May 10, 2024
Merged

Allow both service_worker and scripts in MV3 Web Extensions #9673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b9ea91
Allow both service_worker and scripts in MV3
mischnic Apr 27, 2024
4a43f72
support `background.page` and `background.persistent` in MV3
101arrowz May 10, 2024
08a83c4
Lint
mischnic May 10, 2024
6c3b328
Merge branch 'v2' into webext-mv3-scripts
mischnic May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/core/integration-tests/test/integration/webextension-mv3/manifest.json
View file
Open in desktop
Expand Up @@ -4,7 +4,9 @@
"version": "0.1",
"manifest_version": 3,
"background": {
"service_worker": "background.js"
"service_worker": "background.js",
"type": "module",
"scripts": [ "background.js" ]
},
"permissions": [
"scripting",
Expand Down
1 change: 1 addition & 0 deletions packages/core/integration-tests/test/webextension.js
View file
Open in desktop
Expand Up @@ -111,6 +111,7 @@ describe('webextension', function () {
assets: ['manifest.json'],
},
{assets: ['background.js']},
{assets: ['background.js']},
{assets: ['popup.html']},
{assets: ['popup.css']},
{assets: ['popup.js', 'esmodule-helpers.js', 'bundle-url.js']},
Expand Down
3 changes: 2 additions & 1 deletion packages/transformers/webextension/src/WebExtensionTransformer.js
View file
Open in desktop
Expand Up @@ -273,7 +273,8 @@ async function collectDependencies(
...getJSONSourceLocation(ptrs['/background/page'], 'value'),
},
});
} else if (program.background?.service_worker) {
}
if (program.background?.service_worker) {
program.background.service_worker = asset.addURLDependency(
program.background.service_worker,
{
Expand Down
4 changes: 4 additions & 0 deletions packages/transformers/webextension/src/schema.js
View file
Open in desktop
Expand Up @@ -473,6 +473,10 @@ export const MV3Schema = ({
type: 'string',
enum: ['classic', 'module'],
},
// to support both Chrome and Firefox
scripts: arrStr,
page: string,
persistent: boolean,
},
additionalProperties: false,
required: ['service_worker'],
Expand Down