Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start to add rust backed request execution under a feature-flag by rewriting ConfigRequest #9658

Merged
merged 32 commits into from May 1, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
15ae074
Start adding rust backed config request
yamadapc Apr 18, 2024
1e3b9a2
Start to add tests and use-case
yamadapc Apr 19, 2024
6257ea0
Add tests for config request
yamadapc Apr 19, 2024
e510d51
Fix more config API bits
yamadapc Apr 19, 2024
f455d03
Add missing tests and fix bug in config request
yamadapc Apr 19, 2024
7533648
Add missing documentation
yamadapc Apr 19, 2024
d4da504
Try implement read_config bits
yamadapc Apr 19, 2024
778e694
Fix flow errors
yamadapc Apr 22, 2024
d044592
Add more tests for config request implementation
yamadapc Apr 22, 2024
274b3b4
Finish migrating config request
yamadapc Apr 22, 2024
d8a691c
Fix flow errors on ConfigRequest.test.js
yamadapc Apr 22, 2024
d455371
Fix linter errors on added tests
yamadapc Apr 22, 2024
3efd232
Minor improvements to rust code
yamadapc Apr 22, 2024
f21b7ec
Merge remote-tracking branch 'upstream/v2' into issue/rust-starting-r…
yamadapc Apr 22, 2024
9e1d121
Fix worker path being passed to memory fs
yamadapc Apr 22, 2024
6f639ac
Merge remote-tracking branch 'upstream/v2' into issue/rust-starting-r…
yamadapc Apr 22, 2024
33387e0
Fix test that was not running
yamadapc Apr 22, 2024
48ee004
Try to fix windows unit-tests
yamadapc Apr 22, 2024
1ef9a93
Merge branch 'v2' into issue/rust-starting-requests
yamadapc Apr 23, 2024
0f939cd
Update Cargo.lock
yamadapc Apr 24, 2024
36ee4a8
Fix broken CLIReporter tests
yamadapc Apr 24, 2024
d5984cc
Fix CLI reporter tests
yamadapc Apr 24, 2024
db029ce
Merge remote-tracking branch 'upstream/v2' into issue/rust-starting-r…
yamadapc Apr 30, 2024
c096d34
Update node-bindings formatting
yamadapc Apr 30, 2024
e8cb988
Merge branch 'v2' into issue/rust-starting-requests
yamadapc Apr 30, 2024
c8ae4a9
Merge branch 'v2' into issue/rust-starting-requests
yamadapc Apr 30, 2024
4bfff78
Try to fix adjacency list test timeouts
yamadapc May 1, 2024
b257eb3
Make changes look better
yamadapc May 1, 2024
8c3a0d9
Increase timeout to 30s
yamadapc May 1, 2024
a52a7bd
Start less workers
yamadapc May 1, 2024
fee2b29
Revert timeout to where it was
yamadapc May 1, 2024
c3603df
Update the CI workflow
yamadapc May 1, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .mocharc.json
@@ -1,5 +1,5 @@
{
"spec": "packages/*/!(integration-tests)/test/*.js",
"spec": "packages/*/!(integration-tests)/test/{*.js,**/*.{test,spec}.js}",
yamadapc marked this conversation as resolved.
Show resolved Hide resolved
"require": ["@parcel/babel-register", "@parcel/test-utils/src/mochaSetup.js"],
// TODO: Remove this when https://github.com/nodejs/node/pull/28788 is resolved
yamadapc marked this conversation as resolved.
Show resolved Hide resolved
"exit": true
Expand Down
124 changes: 110 additions & 14 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions crates/node-bindings/Cargo.toml
Expand Up @@ -14,6 +14,12 @@ parcel-resolver = { path = "../../packages/utils/node-resolver-rs" }
dashmap = "5.4.0"
xxhash-rust = { version = "0.8.2", features = ["xxh3"] }

serde = "1.0.198"
serde_json = "1.0.116"
toml = "0.8.12"
anyhow = "1.0.82"
mockall = "0.12.1"

[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
napi = {version = "2.12.6", features = ["serde-json", "napi4", "napi5"]}
parcel-dev-dep-resolver = { path = "../../packages/utils/dev-dep-resolver" }
Expand All @@ -35,5 +41,7 @@ jemallocator = { version = "0.3.2", features = ["disable_initial_exec_tls"] }
[target.'cfg(windows)'.dependencies]
mimalloc = { version = "0.1.25", default-features = false }

[dev-dependencies]

[build-dependencies]
napi-build = "2"
4 changes: 4 additions & 0 deletions crates/node-bindings/src/core/mod.rs
@@ -0,0 +1,4 @@
//! Core re-implementation in Rust

/// Request types and run functions
mod requests;