Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webmanifest - Add support for icons in file_handlers #9152

Merged
merged 5 commits into from Sep 27, 2023

Conversation

grimsteel
Copy link
Contributor

↪️ Pull Request

This adds support for bundling images referenced in file handler icons in webmanifests (related to #8660)

💻 Examples

{
  "name": "Example",
  "icons": [{
    "src": "images/icon48.png",
    "sizes": "48x48",
    "type": "image/png"
  }],
  "file_handlers" : [
    {
      "icons": [{
        "src": "images/file-handler-icon.png",
        "sizes": "48x48",
        "type": "image/png"
      }]
    }
  ]
}

🚨 Test instructions

Covered by webmanifest integration tests

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@grimsteel grimsteel marked this pull request as ready for review July 25, 2023 19:44
Copy link
Member

@mischnic mischnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mischnic mischnic merged commit 801de2c into parcel-bundler:v2 Sep 27, 2023
14 of 15 checks passed
@grimsteel grimsteel deleted the webmanifest-file-handlers branch September 27, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants