Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default interop with re-exports in namespace #7002

Merged
merged 2 commits into from
Oct 4, 2021

Conversation

devongovett
Copy link
Member

@devongovett devongovett commented Oct 1, 2021

Closes #6909

See test case. Previously it resulted in undefined because the interop call was not inserted properly when generating the namespace object.

@height
Copy link

height bot commented Oct 1, 2021

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@mischnic
Copy link
Member

mischnic commented Oct 1, 2021

Is this the same bug as #6909?

@devongovett
Copy link
Member Author

Ah, yup! Looks like it is

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.43s -41.00ms
Cached 361.00ms -10.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 740.00ms +655.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 741.00ms +655.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 740.00ms +654.00ms ⚠️

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description Time Difference
Cold 11.79s -263.00ms
Cached 579.00ms -1.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.31m -113.00ms
Cached 1.87s -177.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/index.7220b9bb.js 1.78mb +4.00b ⚠️ 22.55s -118.00ms
dist/index.41eda219.js 694.71kb -11.00b 🚀 1.01m +535.00ms
dist/editorView.b1936c11.js 594.84kb +0.00b 59.70s +14.76s ⚠️
dist/popup.96b3e5ff.js 209.67kb +0.00b 59.70s +14.75s ⚠️
dist/Toolbar.701cd015.js 107.23kb +0.00b 59.70s +14.76s ⚠️
dist/Modal.01691d6b.js 45.33kb +0.00b 59.70s +14.75s ⚠️
dist/js.0f0bb621.js 17.25kb +0.00b 59.70s +14.75s ⚠️
dist/ui.70a43197.js 14.94kb +0.00b 59.70s +14.75s ⚠️
dist/smartMediaEditor.fd1d06fd.js 13.25kb +0.00b 59.70s +14.76s ⚠️
dist/dropzone.0d183115.js 12.15kb +0.00b 59.70s +14.76s ⚠️
dist/EmojiPickerComponent.55e0a64c.js 3.73kb +0.00b 59.70s +14.75s ⚠️
dist/png-chunks-extract.94b5b9fc.js 3.58kb +0.00b 59.70s +14.75s ⚠️
dist/dropzone.a10cce43.js 3.29kb +0.00b 59.70s +14.76s ⚠️
dist/clipboard.969d5ad7.js 2.93kb +0.00b 59.70s +14.76s ⚠️
dist/ResourcedEmojiComponent.78f6ddfc.js 2.12kb +0.00b 59.70s +14.75s ⚠️
dist/browser.17513657.js 1.69kb +0.00b 59.70s +14.76s ⚠️
dist/media-card-analytics-error-boundary.75fac461.js 1.12kb +0.00b 59.70s +14.76s ⚠️
dist/media-picker-analytics-error-boundary.1602c912.js 966.00b +0.00b 59.70s +14.76s ⚠️
dist/simpleHasher.2a6e12b6.js 643.00b +0.00b 59.70s +14.75s ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/index.32ae08f5.js 1.78mb +2.00b ⚠️ 23.58s +1.25s ⚠️
dist/index.316943c1.js 694.72kb -19.00b 🚀 1.01m +815.00ms
dist/EmojiPickerComponent.d4340aa2.js 146.67kb +0.00b 37.84s +13.64s ⚠️
dist/component.49a60ece.js 37.35kb +0.00b 23.58s +1.25s ⚠️
dist/esm.349b86d2.js 33.15kb +0.00b 37.84s +13.64s ⚠️
dist/component.7733a817.js 24.94kb +0.00b 23.57s +1.25s ⚠️
dist/DatePicker.7311f8b1.js 22.98kb +0.00b 37.84s +13.64s ⚠️
dist/js.0f0bb621.js 17.25kb +0.00b 1.00m +15.49s ⚠️
dist/png-chunks-extract.94b5b9fc.js 3.58kb +0.00b 1.00m +15.49s ⚠️
dist/16.7b42ca8a.js 2.35kb +0.00b 23.57s +1.25s ⚠️
dist/date.c0482a02.js 1.87kb +0.00b 23.57s +1.25s ⚠️
dist/feedback.e18b45f0.js 1.77kb +0.00b 37.84s +13.64s ⚠️
dist/workerHasher.567cfc57.js 1.63kb +0.00b 37.84s +13.64s ⚠️
dist/code.cd95a955.js 1.51kb +0.00b 23.57s +1.25s ⚠️
dist/heading6.b3b946d1.js 1.51kb +0.00b 37.84s +13.64s ⚠️
dist/heading5.e617db66.js 1.38kb +0.00b 37.84s +13.64s ⚠️
dist/expand.1f17de7f.js 1.29kb +0.00b 37.84s +13.64s ⚠️
dist/action.9e337641.js 1.14kb +0.00b 23.57s +1.25s ⚠️
dist/component.edb11b95.js 1.13kb +0.00b 23.57s +1.25s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 8.28s +92.00ms
Cached 447.00ms -28.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit 260cdb8 into v2 Oct 4, 2021
@devongovett devongovett deleted the fix-re-export-interop branch October 4, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants