Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize case of SVG elements and attributes in HTML, and preserve accessibility attributes #6593

Merged
merged 4 commits into from Jul 17, 2021
Merged

Normalize case of SVG elements and attributes in HTML, and preserve accessibility attributes #6593

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed95a56
Normalize case of SVG elements and attributes in HTML, and preserve a…
devongovett Jul 14, 2021
9d501fc
Fix flow
devongovett Jul 14, 2021
c021d71
Fix colon in filename issue on windows
devongovett Jul 14, 2021
e39b35a
Skip colon test entirely on windows
devongovett Jul 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/core/integration-tests/test/html.js
View file
Open in desktop
Expand Up @@ -2322,8 +2322,16 @@ describe('html', function() {
});

it('should work with bundle names that have colons in them', async function() {
// Windows paths cannot contain colons, so write the file here (in memory).
await overlayFS.mkdirp(path.join(__dirname, 'integration/url-colon'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix the colon issue? I notice the benchmarks still fail due to a invalid path with colons and I notice it on other PRs as well. Is that just a bug we introduced somewhere and is now in V2 ? 😟

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should but it seems the test is still failing on windows. I will look into it

await overlayFS.writeFile(
path.join(__dirname, 'integration/url-colon/a:b:c.html'),
'<p>Test</p>',
);

let b = await bundle(
path.join(__dirname, 'integration/url-colon/relative.html'),
{inputFS: overlayFS},
);

assertBundles(b, [
Expand All @@ -2342,6 +2350,7 @@ describe('html', function() {

b = await bundle(
path.join(__dirname, 'integration/url-colon/absolute.html'),
{inputFS: overlayFS},
);

assertBundles(b, [
Expand Down
1 change: 0 additions & 1 deletion packages/core/integration-tests/test/integration/url-colon/a:b:c.html
View file
Open in desktop

This file was deleted.