-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for peer dependencies in v2 #3753
Conversation
So if I have We should print a more helpful error (and maybe hint at how to solve this: adding as a peerDependency or a dependency) |
Whats the status of this issue? Seems like there are many issues which are all on the same subject. This looks like the latest conversation about it. it would be amazing if this gets supported. |
This comment has been minimized.
This comment has been minimized.
@subhero24 Can you/do you want to update this? |
Currently the error for the unfound peer dependency is |
#4072 implemented another way of doing this. Gonna close this for now as it's probably no longer needed, feel free to re-open discussion on more excluding of modules improvements |
As requested in #3674 I implemented support for peer dependencies in v2 with integration tests.
This changes the module resolution to discard packages that where specified as peer dependencies. It also excludes files from the bundle if all references to a package where specified as a peer dependency.
This solves issues:
#144
#3305