Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Markdown support — v2 #2882

Conversation

kirillrogovoy
Copy link
Contributor

↪️ Markdown support — v2

Implements what originally was asked in #2274.

New features:

  • Front matter support
  • Templating support via Mustache templates
  • Specifying options for Marked via marked.config.js
  • Specifying options for Marked via Front matter attributes

See integration tests for examples.

I'll be happy to write the docs for Markdown support once we settle on these changes.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@kirillrogovoy
Copy link
Contributor Author

cc @LandonSchropp @Benjmhart

@kirillrogovoy
Copy link
Contributor Author

cc @tomfinney — should solve your issue here: #2538 (comment)

@mischnic @devongovett Hey!
I know the project's been intense, but could you give a rough estimate on when you would be able to look at the changes?

Maybe there's something inherently wrong with this PR and you would send me back to the workbench having spent just a minute? 😅

@mischnic
Copy link
Member

Parcel 1 is feature-locked because of the ongoing development of Parcel 2. So this is very unlikely to be merged.

@kirillrogovoy
Copy link
Contributor Author

@mischnic Thanks for your reply!

  1. Does that mean that I could get it merged into v2 somehow?
  2. If the issue is the breaking changes, why did Add Markdown support as an entry point (issue #2274) #2538 get into master then? 🙂 It did contain breaking changes for how we treat Markdown files. This PR is just finishing what I've started there.

@tomfinney
Copy link

@kirillrogovoy the front matter stuff looks dope.

It seems weird that this would not get merged into 1.x.x as the initial version of markdown processing was merged in. One my projects is currently locked to a specific version of Parcel prior to that because the update broke how I parsed meta data from the markdown files. Seems weird to let that in but to not then tie up all the loose threads.

@DeMoorJasper
Copy link
Member

@kirillrogovoy it could get merged into v2. Although it’s probably better to wait untill we’ve figured out html for v2

Sent with GitHawk

@kirillrogovoy
Copy link
Contributor Author

I don't mind waiting for v2. Although I'm still concerned with what @tomfinney and I mentioned.

We already have Markdown support in master, but it's very limited.

It made sense to not merge the preceding PR (#2538) due to the feature lock, but it makes less sense to not get it finished since we did merge it.

@DeMoorJasper
Copy link
Member

gonna close this due to Parcel 1 not receiving any new features

@DeMoorJasper DeMoorJasper mentioned this pull request Dec 22, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants