Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace module.require in scope hoisting #2875

Merged
merged 3 commits into from May 8, 2019
Merged

Replace module.require in scope hoisting #2875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
271d000
Replace module.require in scope hoisting
mischnic Apr 1, 2019
7ba7933
Merge branch 'master' of github.com:parcel-bundler/parcel into hoist-…
devongovett May 8, 2019
655aae2
Add test
devongovett May 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/integration-tests/test/integration/scope-hoisting/commonjs/module-object/a.js
View file
Open in desktop
@@ -1,6 +1,7 @@
output = {
id: module.id,
hot: module.hot,
moduleRequire: module.require,
type: typeof module,
exports: exports,
exportsType: typeof exports,
Expand Down
1 change: 1 addition & 0 deletions packages/core/integration-tests/test/scope-hoisting.js
View file
Open in desktop
Expand Up @@ -908,6 +908,7 @@ describe('scope hoisting', function() {
let output = await run(b);
assert.equal(output.id, b.entryAsset.id);
assert.equal(output.hot, null);
assert.equal(output.moduleRequire, null);
assert.equal(output.type, 'object');
assert.deepEqual(output.exports, {});
assert.equal(output.exportsType, 'object');
Expand Down
7 changes: 7 additions & 0 deletions packages/core/parcel-bundler/src/scope-hoisting/hoist.js
View file
Open in desktop
Expand Up @@ -191,6 +191,13 @@ module.exports = {
path.replaceWith(t.identifier('null'));
}

if (
t.matchesPattern(path.node, 'module.require') &&
asset.options.target !== 'node'
) {
path.replaceWith(t.identifier('null'));
}

if (t.matchesPattern(path.node, 'module.bundle')) {
path.replaceWith(t.identifier('require'));
}
Expand Down