Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defer throwing asset errors until after dependencies are handled. #2475

Merged
merged 9 commits into from Jan 3, 2019
Merged

Defer throwing asset errors until after dependencies are handled. #2475

merged 9 commits into from Jan 3, 2019

Commits on Dec 28, 2018

  1. Defer throwing asset errors until after dependencies are handled. 

    This allows compiled langauges like Elm that handle their own dependency
compilation to set up watchers for dependencies so that hot-reload
continues to work due to errors in new depdenencies. Fixes parcel-bundler#2147.
    @MattCheely
    MattCheely committed Dec 28, 2018
    Copy the full SHA
    c36d1a7 View commit details
    Browse the repository at this point in the history

  2. Fix Elm error generation. 

    I'm not entirely sure why this fix is necessary, but without it a
compile error during a rebuild results in Parcel printing "Unknown
error" instead of anything useful. Since we are intecepting the error
though, we can also remove redundant stack information.
    @MattCheely
    MattCheely committed Dec 28, 2018
    Copy the full SHA
    e7ba284 View commit details
    Browse the repository at this point in the history

  3. Add test for tracking dependencies on error

    @MattCheely
    MattCheely committed Dec 28, 2018
    Copy the full SHA
    1315f35 View commit details
    Browse the repository at this point in the history

  4. revert hmr-runtime changes

    @MattCheely
    MattCheely committed Dec 28, 2018
    Copy the full SHA
    83335d1 View commit details
    Browse the repository at this point in the history

  5. Transform all errors in Pipeline.process. 

    This prevents error data from being lost when Pipeline is run via
`WorkerFarm`.
    @MattCheely
    MattCheely committed Dec 28, 2018
    Copy the full SHA
    077f20e View commit details
    Browse the repository at this point in the history

  6. Separate error-depenency test input from basic Elm tests.

    @MattCheely
    MattCheely committed Dec 28, 2018
    Copy the full SHA
    a6b9358 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2018

  1. Update ElmAsset.js

    @DeMoorJasper
    DeMoorJasper committed Dec 31, 2018
    1
    Copy the full SHA
    e1f027f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into improve-dep-error-handling

    @DeMoorJasper
    DeMoorJasper committed Dec 31, 2018
    Copy the full SHA
    0a2943a View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2019

  1. Merge branch 'master' into improve-dep-error-handling

    @DeMoorJasper
    DeMoorJasper committed Jan 2, 2019
    Copy the full SHA
    c808a4d View commit details
    Browse the repository at this point in the history