Defer throwing asset errors until after dependencies are handled. #2468
Conversation
This allows compiled langauges like Elm that handle their own dependency compilation to set up watchers for dependencies so that hot-reload continues to work due to errors in new depdenencies. Fixes parcel-bundler#2147.
|
FWIW, I made some changes to my original branch that got my local test runs in a consistent state with master (not everything succeeds, but the same things fail), but It looks like the addition of elm-hot has mooted the need for this fix for Elm assets, although it could still be useful for other languages. It does mean my primary test app is no longer useful for testing though. |
|
@MattCheely I still get the same bug, why do you think elm-hot changed anything? |
|
@domenkozar 🤦♂️ Looks like you are right and it is still an issue. I was working on this at a meetup last night and during testing with a local up-to-date parcel install, it seemed like things were working, but reviewing things now, I must have made a mistake somewhere in that verification. I can look at this some more tonight - it seems the latest changes in my branch are also no longer fixing the issue, but until I look closer, I'm not sure whether I introduced the problem when fixing test failures or it's related to the elm-hot changes. Feel free to take a look in the meantime if you have the time and inclination. |
|
@domenkozar I think I have resolved all of my previous issues in #2475. I think we can close this PR, if that's OK with you. |
Testing #2344 with following changes:
(lost original authorship of the commit, hopefully we can fix this before merging)