Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-updating asset hashes #1861

Merged
merged 5 commits into from Aug 24, 2018
Merged

Fix non-updating asset hashes #1861

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
be54b08
add content hash to asset hash
DeMoorJasper Aug 7, 2018
28d93b8
move assethash to pipeline
DeMoorJasper Aug 23, 2018
66f7f41
hopefully fix merge conflict
DeMoorJasper Aug 23, 2018
7614701
merge
DeMoorJasper Aug 23, 2018
09138cd
move hashes back into asset
DeMoorJasper Aug 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Asset.js
View file
Open in desktop
Expand Up @@ -214,7 +214,13 @@ class Asset {
}

generateHash() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this method needed anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RawAsset uses it as it has no generated content

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should keep the method then and just call it after post-processing is done?

return objectHash(this.generated);
let contentHash = '';
try {
contentHash = md5(this.contents);
} catch (err) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case this.contents is not a string or undefined

// ignore
}
return md5(objectHash(this.generated) + contentHash);
}

invalidate() {
Expand Down