Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process inline styles and scripts #1456

Merged
merged 15 commits into from Jul 21, 2018
Merged

Process inline styles and scripts #1456

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f09cfc5
process inline style && scripts
DeMoorJasper May 29, 2018
a612b82
minor fix
DeMoorJasper May 29, 2018
63cd6c8
add bg-img test
DeMoorJasper Jun 14, 2018
d7e5e85
Merge branch 'master' into feature/inline-processing
DeMoorJasper Jul 11, 2018
0480066
fix conflict
Jul 17, 2018
611a2ab
fix conflict
Jul 17, 2018
a496c4a
fix html test
Jul 17, 2018
0c2bbd5
restore failing json test
Jul 17, 2018
b5de45f
add support for custom style syntaxes
DeMoorJasper Jul 17, 2018
5524c82
support custom scripting languages inline
DeMoorJasper Jul 17, 2018
3b5c509
inline coffee test
DeMoorJasper Jul 18, 2018
7a6d18c
fix json
DeMoorJasper Jul 18, 2018
d6facce
Slight simplification
devongovett Jul 21, 2018
bc2a891
Revert formatting changes
devongovett Jul 21, 2018
9451aa1
Handle imports in <script> and <style> tags
devongovett Jul 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/assets/HTMLAsset.js
View file
Open in desktop
Expand Up @@ -204,8 +204,6 @@ class HTMLAsset extends Asset {
}
}

console.log(type);

parts.push({type, value});

if (!node.attrs) {
Expand Down
16 changes: 16 additions & 0 deletions test/html.js
View file
Open in desktop
Expand Up @@ -638,4 +638,20 @@ describe('html', function() {

assert(html.includes('<style type="text/css">.index{color:#00f}</style>'));
});

it.only('should process inline non-js scripts', async function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up, you've left an only call here

let b = await bundle(
__dirname + '/integration/html-inline-coffeescript/index.html',
{production: true}
);

await assertBundleTree(b, {
name: 'index.html',
assets: ['index.html']
});

let html = await fs.readFile(__dirname + '/dist/index.html', 'utf8');

assert(html.includes('alert("Hello, World!")'));
});
});
11 changes: 11 additions & 0 deletions test/integration/html-inline-coffeescript/index.html
View file
Open in desktop
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Inline JavaScript Parcel</title>
</head>
<body>
<script type="application/coffee">
alert "Hello, World!"
</script>
</body>
</html>