Update getPackageMain logic to retrieve the first entry that exists #1237
Conversation
| const stat = await fs.stat(entry); | ||
| if (stat.isDirectory()) return path.resolve(entry, 'index'); | ||
| return entry; | ||
| } catch (e) { |
There was a problem hiding this comment.
I think we should just blow-up here if an entry record declared in package.json doesn't exists instead of handling it.
Codecov Report
@@ Coverage Diff @@
## master #1237 +/- ##
=========================================
+ Coverage 88.28% 88.59% +0.3%
=========================================
Files 77 77
Lines 4355 4356 +1
=========================================
+ Hits 3845 3859 +14
+ Misses 510 497 -13
Continue to review full report at Codecov.
|
| if (!main || main === '.' || main === './') { | ||
| main = 'index'; | ||
| try { | ||
| const stat = await fs.stat(entry); |
There was a problem hiding this comment.
Maybe instead of doing the actual resolution here (and then duplicating it again later), we could just have getPackageMain return an array of possible paths. Then, loadDirectory could just loop through them and try each one: https://github.com/parcel-bundler/parcel/blob/master/src/Resolver.js#L188-L191
There was a problem hiding this comment.
Ok, but I'm a little bit busy right now. I'll come back and take a deeper look into this next month.
|
Closing in favor of #1577. |
Currently, node_modules package entry is resolved in the following order.
pkg.module -> pkg['jsnext:main'] -> pkg.browser -> pkg.main ->
${pkg.pkgdir}/index.jsI keep the same order but will fallback to the first EXISTS entry. That way we can avoid common library author mistakes, which results in a lot of
cannot resolve dependency...issues.