Add support for SharedWorkers (#1907)

Closes #1905
parcel-bundler · Aug 19, 2018 · b17316b · b17316b
1 parent 9ea8eea
commit b17316b
Show file tree

Hide file tree

Showing 8 changed files with 29 additions and 3 deletions.
diff --git a/packages/core/parcel/src/Parser.js b/packages/core/parcel/src/Parser.js
@@ -83,4 +83,4 @@ class Parser {
   }
 }
 
-module.exports = Parser;
+module.exports = Parser;
diff --git a/packages/core/parcel/src/assets/JSAsset.js b/packages/core/parcel/src/assets/JSAsset.js
@@ -22,7 +22,7 @@ const ENV_RE = /\b(?:process\.env)\b/;
 const GLOBAL_RE = /\b(?:process|__dirname|__filename|global|Buffer|define)\b/;
 const FS_RE = /\breadFileSync\b/;
 const SW_RE = /\bnavigator\s*\.\s*serviceWorker\s*\.\s*register\s*\(/;
-const WORKER_RE = /\bnew\s*Worker\s*\(/;
+const WORKER_RE = /\bnew\s*(?:Shared)?Worker\s*\(/;
 const SOURCEMAP_RE = /\/\/\s*[@#]\s*sourceMappingURL\s*=\s*([^\s]+)/;
 const DATA_URL_RE = /^data:[^;]+(?:;charset=[^;]+)?;base64,(.*)/;
 

diff --git a/packages/core/parcel/src/visitors/dependencies.js b/packages/core/parcel/src/visitors/dependencies.js
@@ -81,7 +81,7 @@ module.exports = {
 
     const isWebWorker =
       callee.type === 'Identifier' &&
-      callee.name === 'Worker' &&
+      (callee.name === 'Worker' || callee.name === 'SharedWorker') &&
       args.length === 1 &&
       types.isStringLiteral(args[0]);
 

diff --git a/packages/core/parcel/test/integration/workers/index-alternative.js b/packages/core/parcel/test/integration/workers/index-alternative.js
@@ -1,4 +1,5 @@
 exports.startWorker = require('./worker-client').startWorker;
+exports.startSharedWorker = require('./worker-client').startSharedWorker;
 exports.commonFunction = require('./common').commonFunction;
 exports.feature = require('./feature');
 
diff --git a/packages/core/parcel/test/integration/workers/index.js b/packages/core/parcel/test/integration/workers/index.js
@@ -1,4 +1,5 @@
 exports.commonFunction = require('./common').commonFunction;
 exports.startWorker = require('./worker-client').startWorker;
+exports.startSharedWorker = require('./worker-client').startSharedWorker;
 exports.feature = require('./feature');
 
diff --git a/packages/core/parcel/test/integration/workers/shared-worker.js b/packages/core/parcel/test/integration/workers/shared-worker.js
@@ -0,0 +1,5 @@
+onconnect = (e) => {
+  let port = e.ports[0];
+  port.addEventListener('message', ()=> {});
+  port.start();
+}
diff --git a/packages/core/parcel/test/integration/workers/worker-client.js b/packages/core/parcel/test/integration/workers/worker-client.js
@@ -7,5 +7,8 @@ exports.startWorker = function() {
   worker.postMessage(commonText);
 };
 
+exports.startSharedWorker = function() {
+  const worker = new SharedWorker('shared-worker.js');
+};
 
 
diff --git a/packages/core/parcel/test/javascript.js b/packages/core/parcel/test/javascript.js
@@ -220,6 +220,14 @@ describe('javascript', function() {
             }
           ]
         },
+        {
+          assets: ['shared-worker.js'],
+          childBundles: [
+            {
+              type: 'map'
+            }
+          ]
+        },
         {
           assets: ['worker.js', 'common.js'],
           childBundles: [
@@ -257,6 +265,14 @@ describe('javascript', function() {
             }
           ]
         },
+        {
+          assets: ['shared-worker.js'],
+          childBundles: [
+            {
+              type: 'map'
+            }
+          ]
+        },
         {
           assets: ['worker.js', 'common.js'],
           childBundles: [