Replace module.require in scope hoisting (#2875)

parcel-bundler · May 8, 2019 · a50ddd5 · a50ddd5
1 parent f3990f3
commit a50ddd5
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/packages/core/integration-tests/test/integration/scope-hoisting/commonjs/module-object/a.js b/packages/core/integration-tests/test/integration/scope-hoisting/commonjs/module-object/a.js
@@ -1,6 +1,7 @@
 output = {
   id: module.id,
   hot: module.hot,
+  moduleRequire: module.require,
   type: typeof module,
   exports: exports,
   exportsType: typeof exports,

diff --git a/packages/core/integration-tests/test/scope-hoisting.js b/packages/core/integration-tests/test/scope-hoisting.js
@@ -908,6 +908,7 @@ describe('scope hoisting', function() {
       let output = await run(b);
       assert.equal(output.id, b.entryAsset.id);
       assert.equal(output.hot, null);
+      assert.equal(output.moduleRequire, null);
       assert.equal(output.type, 'object');
       assert.deepEqual(output.exports, {});
       assert.equal(output.exportsType, 'object');

diff --git a/packages/core/parcel-bundler/src/scope-hoisting/hoist.js b/packages/core/parcel-bundler/src/scope-hoisting/hoist.js
@@ -191,6 +191,13 @@ module.exports = {
       path.replaceWith(t.identifier('null'));
     }
 
+    if (
+      t.matchesPattern(path.node, 'module.require') &&
+      asset.options.target !== 'node'
+    ) {
+      path.replaceWith(t.identifier('null'));
+    }
+
     if (t.matchesPattern(path.node, 'module.bundle')) {
       path.replaceWith(t.identifier('require'));
     }