Move parcel version up to ParcelOptions

parcel-bundler · Apr 26, 2024 · 9809e9e · 9809e9e
1 parent 150947c
commit 9809e9e
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/packages/core/core/src/public/PluginOptions.js b/packages/core/core/src/public/PluginOptions.js
@@ -13,7 +13,6 @@ import type {FileSystem} from '@parcel/fs';
 import type {PackageManager} from '@parcel/package-manager';
 import type {ParcelOptions} from '../types';
 import {type FeatureFlags} from '@parcel/feature-flags';
-import {PARCEL_VERSION} from '../constants';
 
 let parcelOptionsToPluginOptions: WeakMap<ParcelOptions, PluginOptions> =
   new WeakMap();
@@ -45,7 +44,7 @@ export default class PluginOptions implements IPluginOptions {
   }
 
   get parcelVersion(): string {
-    return PARCEL_VERSION;
+    return this.#options.parcelVersion;
   }
 
   get hmrOptions(): ?HMROptions {

diff --git a/packages/core/core/src/resolveOptions.js b/packages/core/core/src/resolveOptions.js
@@ -26,6 +26,7 @@ import {toProjectPath} from './projectPath';
 import {getResolveFrom} from './requests/ParcelConfigRequest';
 
 import {DEFAULT_FEATURE_FLAGS} from '@parcel/feature-flags';
+import {PARCEL_VERSION} from './constants';
 
 // Default cache directory name
 const DEFAULT_CACHE_DIRNAME = '.parcel-cache';
@@ -223,6 +224,7 @@ export default async function resolveOptions(
       isLibrary: initialOptions?.defaultTargetOptions?.isLibrary,
     },
     featureFlags: {...DEFAULT_FEATURE_FLAGS, ...initialOptions?.featureFlags},
+    parcelVersion: PARCEL_VERSION,
   };
 }
 

diff --git a/packages/core/core/src/types.js b/packages/core/core/src/types.js
@@ -274,6 +274,7 @@ export type ParcelOptions = {|
   config?: DependencySpecifier,
   defaultConfig?: DependencySpecifier,
   env: EnvMap,
+  parcelVersion: string,
   targets: ?(Array<string> | {+[string]: TargetDescriptor, ...}),
   shouldDisableCache: boolean,
   cacheDir: FilePath,

diff --git a/packages/core/core/test/test-utils.js b/packages/core/core/test/test-utils.js
@@ -17,6 +17,7 @@ cache.ensure();
 
 export const DEFAULT_OPTIONS: ParcelOptions = {
   cacheDir: path.join(__dirname, '.parcel-cache'),
+  parcelVersion: '',
   watchDir: __dirname,
   watchIgnore: undefined,
   watchBackend: undefined,