fix sass url loader (#1909)

parcel-bundler · Aug 23, 2018 · 6ef0786 · 6ef0786
1 parent ffef2c1
commit 6ef0786
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/src/assets/SASSAsset.js b/src/assets/SASSAsset.js
@@ -40,13 +40,6 @@ class SASSAsset extends Asset {
         ? opts.indentedSyntax
         : type === 'sass';
 
-    opts.functions = Object.assign({}, opts.functions, {
-      'url($url)': url => {
-        let filename = this.addURLDependency(url.getValue());
-        return new sass.types.String(`url(${JSON.stringify(filename)})`);
-      }
-    });
-
     opts.importer = opts.importer || [];
     opts.importer = Array.isArray(opts.importer)
       ? opts.importer
@@ -83,8 +76,7 @@ class SASSAsset extends Asset {
     return [
       {
         type: 'css',
-        value: this.ast ? this.ast.css.toString() : '',
-        hasDependencies: false
+        value: this.ast ? this.ast.css.toString() : ''
       }
     ];
   }

diff --git a/test/integration/scss-url/image.jpeg b/test/integration/scss-url/image.jpeg
diff --git a/test/integration/scss-url/index.scss b/test/integration/scss-url/index.scss
@@ -6,3 +6,7 @@
 .index {
   background: url("http://google.com");
 }
+
+.something {
+  background: url(./image.jpeg);
+}
diff --git a/test/sass.js b/test/sass.js
@@ -116,6 +116,11 @@ describe('sass', function() {
       name: 'index.js',
       assets: ['index.js', 'index.scss'],
       childBundles: [
+        {
+          type: 'jpeg',
+          assets: ['image.jpeg'],
+          childBundles: []
+        },
         {
           type: 'map'
         },