Don't retarget dependencies with * (#8645)

packages/core/core/src/BundleGraph.js

@@ -215,6 +215,10 @@ export default class BundleGraph {
           node.usedSymbolsUp.size > 0 &&
           // Only perform rewriting if the dependency only points to a single asset (e.g. CSS modules)
           !hasAmbiguousSymbols &&
+          // It doesn't make sense to retarget dependencies where `*` is used, because the
+          // retargeting won't enable any benefits in that case (apart from potentially even more
+          // code being generated).
+          !node.usedSymbolsUp.has('*') &&
           // TODO We currently can't rename imports in async imports, e.g. from
           //      (parcelRequire("...")).then(({ a }) => a);
           // to

packages/core/integration-tests/test/integration/scope-hoisting/es6/retarget-namespace-single/index.js

@@ -0,0 +1,5 @@
+import { v } from "./library/a.js";
+
+import * as y from "./library/a.js";
+
+output = [v, sideEffectNoop(y).v];

packages/core/integration-tests/test/integration/scope-hoisting/es6/retarget-namespace-single/library/a.js

@@ -0,0 +1 @@
+export * from "./b.js";

packages/core/integration-tests/test/integration/scope-hoisting/es6/retarget-namespace-single/library/b.js

@@ -0,0 +1 @@
+export {v} from "./c.js";

packages/core/integration-tests/test/integration/scope-hoisting/es6/retarget-namespace-single/library/c.js

@@ -0,0 +1 @@
+export const v = 123;

packages/core/integration-tests/test/integration/scope-hoisting/es6/retarget-namespace-single/library/package.json

@@ -0,0 +1,3 @@
+{
+	"sideEffects": false
+}

packages/core/integration-tests/test/scope-hoisting.js

@@ -2224,6 +2224,17 @@ describe('scope hoisting', function () {
       ]);
     });
 
+    it('should correctly retarget dependencies when both namespace and indvidual export are used', async function () {
+      let b = await bundle(
+        path.join(
+          __dirname,
+          '/integration/scope-hoisting/es6/retarget-namespace-single/index.js',
+        ),
+      );
+      let output = await run(b);
+      assert.deepEqual(output, [123, 123]);
+    });
+
     it('should correctly handle circular dependencies', async function () {
       let b = await bundle(
         path.join(__dirname, '/integration/scope-hoisting/es6/circular/a.mjs'),

packages/core/test-utils/src/utils.js

@@ -338,7 +338,7 @@ export async function runBundles(
 
   // A utility to prevent optimizers from removing side-effect-free code needed for testing
   // $FlowFixMe[prop-missing]
-  ctx.sideEffectNoop = () => {};
+  ctx.sideEffectNoop = v => v;
 
   vm.createContext(ctx);
   let esmOutput;