patch(hmr): use hostname for WS instantiation (#426)

* patch(hmr): use hostname for WS instantiation * test(hmr): add hostname shim for testing * Move location shim somewhere common
parcel-bundler · Dec 29, 2017 · 06d5ffc · 06d5ffc
1 parent 8a65676
commit 06d5ffc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/builtins/hmr-runtime.js b/src/builtins/hmr-runtime.js
@@ -15,7 +15,7 @@ function Module() {
 module.bundle.Module = Module;
 
 if (!module.bundle.parent && typeof WebSocket !== 'undefined') {
-  var ws = new WebSocket('ws://localhost:{{HMR_PORT}}/');
+  var ws = new WebSocket('ws://' + window.location.hostname + ':{{HMR_PORT}}/');
   ws.onmessage = function(event) {
     var data = JSON.parse(event.data);
 

diff --git a/test/utils.js b/test/utils.js
@@ -78,11 +78,14 @@ function run(bundle, globals) {
     {
       document: fakeDocument,
       WebSocket,
-      console
+      console,
+      location: {hostname: 'localhost'}
     },
     globals
   );
 
+  ctx.window = ctx;
+
   vm.createContext(ctx);
   vm.runInContext(fs.readFileSync(bundle.name), ctx);
   return ctx.require(bundle.entryAsset.id);