Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not abort connection on unsupported public key #2323

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

do not abort connection on unsupported public key #2323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db4e622
do not abort connection on unsupported public key
torkve Nov 3, 2023
056132f
flake8
torkve Nov 3, 2023
28e6fc3
add changelog record
torkve Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 9 additions & 6 deletions paramiko/auth_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,13 +625,16 @@ def _parse_userauth_request(self, m):
msg = "Auth rejected: unsupported or mangled public key ({}: {})" # noqa
self._log(INFO, msg.format(e.__class__.__name__, e))
key = None

if key is None:
self._disconnect_no_more_auth()
return
# first check if this key is okay... if not, we can skip the verify
result = self.transport.server_object.check_auth_publickey(
username, key
)
# if no key has been decoded, fast fail this auth attempt
result = AUTH_FAILED
else:
# first check if this key is okay...
# if not, we can skip the verify
result = self.transport.server_object.check_auth_publickey(
username, key
)
if result != AUTH_FAILED:
# key is okay, verify it
if not sig_attached:
Expand Down
2 changes: 2 additions & 0 deletions sites/www/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
Changelog
=========

- :bug:`2322` Fixed premature server connection closure when a client
attempts to send an unsupported key. Patch by ``@torkve``.
- :release:`3.3.1 <2023-07-28>`
- :bug:`-` Cleaned up some very old root level files, mostly just to exercise
some of our doc build and release machinery. This changelog entry
Expand Down