-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ssh config include #2307
Open
mrmeszaros
wants to merge
17
commits into
paramiko:main
Choose a base branch
from
mrmeszaros:config-includes
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jan 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 19d8aa8 - Browse repository at this point
Copy the full SHA 19d8aa8View commit details -
Add support for relative includes from user home
Based on the ssh_config man pages relative includes should use the default ssh config home (~/.ssh) as a base
Configuration menu - View commit details
-
Copy full SHA for 82b95d5 - Browse repository at this point
Copy the full SHA 82b95d5View commit details -
Make include handle invalid paths
Just as openssh, it will currently silently ignore missing files.
Configuration menu - View commit details
-
Copy full SHA for b042222 - Browse repository at this point
Copy the full SHA b042222View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5d280c - Browse repository at this point
Copy the full SHA a5d280cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b06cc2f - Browse repository at this point
Copy the full SHA b06cc2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f8271c5 - Browse repository at this point
Copy the full SHA f8271c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7208ecf - Browse repository at this point
Copy the full SHA 7208ecfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cef3b2 - Browse repository at this point
Copy the full SHA 8cef3b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 356efab - Browse repository at this point
Copy the full SHA 356efabView commit details -
Configuration menu - View commit details
-
Copy full SHA for b9998fb - Browse repository at this point
Copy the full SHA b9998fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for dec4a04 - Browse repository at this point
Copy the full SHA dec4a04View commit details -
This solution is kind of hacky, as it breaks up the context blocks into parts based on the `Include`, so that they are used in the order of definition and not at the end of the block. A proper solution would be to use an ordered collection of options, during parsing, that ensures ordered lookup during the lookup phase. OrderedDict was tried as a drop-in, but it is not sufficient enough, as defined in the include-order-2 test case.
Configuration menu - View commit details
-
Copy full SHA for d7191d0 - Browse repository at this point
Copy the full SHA d7191d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for dac83c3 - Browse repository at this point
Copy the full SHA dac83c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bb524f - Browse repository at this point
Copy the full SHA 0bb524fView commit details -
Remove unused deprecated self._config field
The storage of the parsed configs might need to be reviewed, as the include support introduced complexity. Due to how includes work, the order of the include is also relevant during lookup time. One possible solution would be to flatten the parsed config: to compile the host/match conditions through includes during parsing. This way the lookup could be much simpler.
Configuration menu - View commit details
-
Copy full SHA for 1ec4d95 - Browse repository at this point
Copy the full SHA 1ec4d95View commit details
Commits on Feb 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4b7142e - Browse repository at this point
Copy the full SHA 4b7142eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 39d82a1 - Browse repository at this point
Copy the full SHA 39d82a1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.