Include dev-requirements.txt in MANIFEST.in. Issue #2246

[marston19]

Addresses #2246 - Include dev-requirements.txt in MANIFEST.in so sdist packaging get the necessary requirements to install and run tests.

[bskinn]

@mtelka, can you test your packaging workflow on @marston19's feature branch to make sure the only thing missing in the manifest was dev-requirements.txt?

[mtelka]

I tried to run tests for 3.3.1 both github tarball and PyPI sdist and test results are same. So the only difference in my use case is missing dev-requirements.txt file. Sorry, I cannot test the branch because I have no sdist from it. I can try to build it myself, but IIRC the result highly depends on tooling used to build sdist.

Thank you.

[bskinn]

Sorry, I cannot test the branch because I have no sdist from it.

Ahh, of course, you need the sdist as it would be built from the project side.

I'll look into this and see what I can do for you.

[bskinn]

Although, looking at the CircleCI output, it did include dev-requirements.txt in the manifest when it built.

So, the easiest (albeit slow) approach might be to merge and release this MANIFEST.in change, and then see how it works. If the MANIFEST still isn't right, we can fix further.

[mtelka]

That sounds like a plan :-). Please note that I do not need new paramiko release with this fix only. For the time being I just switched to github tarball.

Thank you!

[mtelka]

While talking about this... If you are open to make my life even more easier, then something like this would be highly appreciated.

Thank you!

[bskinn]

While talking about this... If you are open to make my life even more easier, then something like this would be highly appreciated.

That one would be bitprophet's call.

Could you create a separate PR for adding the stub tox.ini and other related changes? It's a separate question from this ticket, and having it split out will make it easier to review/evaluate.

[mtelka]

Could you create a separate PR for adding the stub tox.ini and other related changes? It's a separate question from this ticket, and having it split out will make it easier to review/evaluate.

Here it is: #2288