Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdist is missing dev-requirements.txt #2246

Open
mtelka opened this issue May 26, 2023 · 2 comments · May be fixed by #2288
Open

sdist is missing dev-requirements.txt #2246

mtelka opened this issue May 26, 2023 · 2 comments · May be fixed by #2288
Labels
Low-hanging fruit Needs patch

Comments

@mtelka
Copy link

mtelka commented May 26, 2023

I'm packaging paramiko for OpenIndiana and I noticed that tests for paramiko fails since there are some packages required by tests not installed. It looks like the list of test dependencies is in the dev-requirements.txt file, but such file is missing from sdist.

Please add dev-requirements.txt to sdist to make downstream testing easier. Thank you.
@bskinn
Copy link
Contributor

bskinn commented May 30, 2023

Seems straightforward enough. While we're looking at this, can you tell if there are any other files missing from the sdist? That is, if you copy over dev-requirements.txt and pip install it, do they run cleanly?

We'd welcome a PR adding the entry to MANIFEST.in.

@marston19
Copy link

Hi, seems super simple, mind if I take this?

marston19 added a commit to marston19/paramiko that referenced this issue Aug 20, 2023
@marston19
Include dev-requirements.txt in MANIFEST.in. Issue paramiko#2246
27901a1 
Include dev-requirements.txt in MANIFEST.in so sdist packaging can make use of test requirements.
@marston19 marston19 mentioned this issue Aug 21, 2023
Open
@mtelka mtelka linked a pull request Aug 23, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Low-hanging fruit Needs patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tox.ini mtelka/paramiko
3 participants
@mtelka @bskinn @marston19