Added SQLiteKeyInfoManager Storage & Retrieval Functionality. #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattDavis00
force-pushed
the
feature-sqlite-key-info-manager
branch
from
388d533
to
fa02a27
Compare
ionut-arm
reviewed
Aug 31, 2021
This commit adds basic storage and retrieval mechanisms into the SQLiteKeyInfoManager. These mechanism satisfy our current unit tests which have been copied from the OnDiskKeyInfoManager for now. Additional unit tests need adding to affirm the key_name, application_name, authenticator namespace we defined during design. Furthermore, the kim_metadata table does not currently exist and will need adding. Closes parallaxsecond#503 Signed-off-by: Matt Davis <matt.davis@arm.com>
MattDavis00
force-pushed
the
feature-sqlite-key-info-manager
branch
from
fa02a27
to
81f3f66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic storage and retrieval mechanisms into the
SQLiteKeyInfoManager.These mechanism satisfy our current unit tests which have been copied from the
OnDiskKeyInfoManagerfor now.Additional unit tests need adding to affirm the
key_name,application_name,authenticatornamespace we defined during design.Furthermore, the
kim_metadatatable does not currently exist and will need adding.(Won't be perfect, just doing it bit by bit for ease of PRs sake)
Closes #503
Signed-off-by: Matt Davis matt.davis@arm.com