Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace JwtSecret with alloy's version of it #8299

Merged
merged 8 commits into from
May 19, 2024
Merged

refactor: Replace JwtSecret with alloy's version of it #8299

merged 8 commits into from
May 19, 2024

Conversation

quentinv72
Copy link
Contributor

Blocked by alloy-rs/alloy#755

Resolves #8276

quentinv72
quentinv72 commented May 17, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@emhane emhane added S-blocked This cannot more forward until something else changes C-debt A section of code is hard to understand or change A-rpc Related to the RPC implementation labels May 18, 2024
mattsse
mattsse approved these changes May 19, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DaniPopes DaniPopes removed the S-blocked This cannot more forward until something else changes label May 19, 2024
@DaniPopes DaniPopes marked this pull request as ready for review May 19, 2024 11:59
@mattsse mattsse enabled auto-merge May 19, 2024 12:33
@mattsse mattsse added this pull request to the merge queue May 19, 2024
Merged via the queue into paradigmxyz:main with commit db9c559 May 19, 2024
29 checks passed
mw2000 pushed a commit to mw2000/reth that referenced this pull request Jun 5, 2024
@quentinv72 @mattsse @mw2000
refactor: Replace JwtSecret with alloy's version of it (paradigmxyz#8299
afb0f97 
)

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-debt A section of code is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace JwtSecret type with alloy's
4 participants
@quentinv72 @mattsse @DaniPopes @emhane