chore(net): integrate discv5 config builder #8289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
C-debt
emhane
requested review from
mattsse,
Rjected,
onbjerg and
gakonst
as code owners
emhane
force-pushed
the
emhane/integrate-discv5
branch
from
a8ab49c
to
64bd7b6
Compare
that pr is the base of this branch |
mattsse
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reth_discv5::ConfigBuilderintoNetworkConfigBuilder.The point of having the builder pattern is to build an immutable type. In this case, the config. The way that the network config is currently being built, makes this difficult. This PR tries to keep discv5 config building coherent with discv4 config building, but respecting the builder pattern.
As many args as possible are added inallDiscoveryArgs::apply_to_builder, but without passing more otherNetworkArgsas parameters than necessary.DiscoveryArgsadded in outer scope, to enable discv5 by default for optimismDiscoveryArgsonNetworkArgstype, are added in the outer scope (NetworkArgs::network_config).NetworkArgs, in the same function they are added wrt to instance to discv4 (NetworkArgs::load_network_config).At best, an issue is made to design the discv4 config to be immutable too, instead of modifying it after it has been built.
Another issue that would make sense, is to move theinstanceflag intoNetworkArgs.--instanceis used inRpcArgstoo, so must exist parallel toNetworkArgsandRpcArgs.